lkml.org 
[lkml]   [2014]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v10 00/10] Support for creating generic PCI host bridges from DT
Date
This is my version 10 of the attempt at adding support for generic PCI host
bridge controllers that make use of device tree information to
configure themselves. This version reverses v9's attempt to create one function
to drive the whole process of extracting the host bridge ranges, setup the
host bridge driver and then scan the root bus behind the host bridge. While it
would've been quite user friendly, I agree that it would've caused a lot of pain
in the future.

I would like to get ACKs for the remaining patches as I would like to integrate
this into -next in the following week.

This version marks an implementation break with the previous versions as
of_create_pci_host_bridge() is now gone. It gets replaced by
of_pci_get_host_bridge_resources() that only parses the DT and extracts the
relevant ranges and converts them to resources. The updated host bridge drivers
will have to follow the guidelines in this example code:

static int foohb_probe(struct platform_device *pdev)
{
struct device_node *dn = pdev->dev.of_node;
struct foohb_drv *drv;
resource_size_t io_base = 0; /* phys address for start of IO */
struct pci_bus *bus;
int err = 0;
LIST_HEAD(res);

.....
err = of_pci_get_host_bridge_resources(dn, 0, 255, &res, &io_base);
if (err)
goto err_handling;
err = foohb_setup(drv, ...., &res, &io_base);
if (err)
goto err_handling;
.....
pci_add_flags(....);
bus = pci_scan_root_bus(&pdev->dev, 0, &foohb_ops, drv, &res);
if (!bus)
goto err_handling;
....
return 0;

err_handling:
......
return err;
}

Changes from v9:
- Moved the DT parsing and assigning of IRQ patch from this series into arm64
specific patch. This keeps existing pcibios_add_device() unchanged and adds
an arch-specific version that can later be expanded to cater for dma_ops.
- Incorporated the fix for users of of_pci_range_to_resources() into the patch
that changes the behaviour for easier bisection.
- Added fixes for tegra and rcar host drivers in their usage of
of_pci_range_to_resources()
- Broke up of_create_pci_host_bridge() to remove the callback function. The
function left has been renamed into of_pci_get_host_bridge_resources(). The
added benefit of that is that the architectural hook for fixing up host bridge
resources now dissappears.
- Reshuffled the way pgprot_device gets introduced. It is now part of the patch
that adds pci_remap_iospace() function. The arm64 specific override is moved
into the arm64 patchset.
- Added a patch to pci_scan_root_bus() to assign unassigned resources if PCI
flags are not PCI_PROBE_ONLY

v9 thread here, with links to previous threads: https://lkml.org/lkml/2014/8/12/361

Best regards,
Liviu

Liviu Dudau (10):
Fix ioport_map() for !CONFIG_GENERIC_IOMAP cases.
PCI: Introduce helper functions to deal with PCI I/O ranges.
ARM: Define PCI_IOBASE as the base of virtual PCI IO space.
PCI: OF: Fix the conversion of IO ranges into IO resources.
PCI: Create pci_host_bridge before its associated bus in
pci_create_root_bus.
PCI: Introduce generic domain handling for PCI busses.
OF: Introduce helper function for getting PCI domain_nr
OF: PCI: Add support for parsing PCI host bridge resources from DT
PCI: Assign unassigned bus resources in pci_scan_root_bus()
PCI: Introduce pci_remap_iospace() for remapping PCI I/O bus resources
into CPU space

arch/arm/include/asm/io.h | 1 +
arch/arm/mach-integrator/pci_v3.c | 23 +++---
drivers/of/address.c | 146 ++++++++++++++++++++++++++++++++++++++
drivers/of/of_pci.c | 136 +++++++++++++++++++++++++++++++++++
drivers/pci/host/pci-tegra.c | 10 ++-
drivers/pci/host/pcie-rcar.c | 21 ++++--
drivers/pci/pci.c | 33 +++++++++
drivers/pci/probe.c | 46 +++++++-----
include/asm-generic/io.h | 2 +-
include/asm-generic/pgtable.h | 4 ++
include/linux/of_address.h | 15 ++--
include/linux/of_pci.h | 18 +++++
include/linux/pci.h | 24 +++++++
13 files changed, 429 insertions(+), 50 deletions(-)

--
2.0.4



\
 
 \ /
  Last update: 2014-09-08 16:21    [W:0.174 / U:1.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site