lkml.org 
[lkml]   [2014]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Patch v4 1/2] freezer: check OOM kill while being frozen
    Hello,

    On Fri, Sep 05, 2014 at 11:12:24AM -0700, Cong Wang wrote:
    > > Rafael, can you please help?
    >
    > Rafael is known not responsive at least for this topic. :)

    :(

    > > Shouldn't the primary goal of the comment be explaining why we need
    > > TIF_MEMDIE check there at all anyway? The deadlock possiblity is not
    > > very obvious.
    >
    > The changelog is not long enough?? ;-) I hate to copy+paste changelog
    > into comments, changelog is essentially necessary for people to understand
    > kernel code (at least networking) , so I don't think we have to move it
    > into comments in this case.

    It doesn't have to be the same text but the current comment is
    basically content-less. e.g. it can just say "OOM killer may get
    stuck trying to kill a cgroup frozen task" and actualy provide
    information on what condition the conditional tries to address.

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2014-09-06 01:21    [W:4.833 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site