lkml.org 
[lkml]   [2014]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 3/3] mfd: palmas: Add support for optional wakeup
On Fri, 5 Sep 2014, Nishanth Menon wrote:
> + if (!palmas->wakeirq)
> + goto no_wake_irq;
> +
> + ret = devm_request_irq(palmas->dev, palmas->wakeirq,
> + palmas_wake_irq,
> + IRQF_ONESHOT | pdata->irq_flags,

Why is this marked IRQF_ONESHOT?

> + dev_name(palmas->dev),
> + &palmas);
> + if (ret < 0)
> + goto err_i2c;

Why err and not doing the obvious clearing of palmas->wakeirq and
keep at least the i2c functional?

Thanks,

tglx


\
 
 \ /
  Last update: 2014-09-05 23:41    [W:0.096 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site