lkml.org 
[lkml]   [2014]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/18] tty: serial: 8250_dma: handle the when UART response while DMA remains idle
    Date
    Sometimes the OMAP UART does not signal the DMA engine to unload the FIFO.
    Usually this happens when we have >threshold bytes in the FIFO
    and start the DMA transfer. It seems that in those cases the UART won't
    trigger the transfer once the requested threshold is reached. In some
    rare cases the UART does not trigger the DMA transfer even if programmed
    while the FIFO was empty.
    In those cases the UART drops an RDI event and we have to empty the FIFO
    manually. If we ignore it because the DMA transfer is programmed then we
    will enter the function a few times until we receive the RX_TIMEOUT
    event. At that point the FIFO is usually full and we risk to overflow
    the FIFO.

    Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    ---
    drivers/tty/serial/8250/8250_dma.c | 18 ++++++++++++++++++
    1 file changed, 18 insertions(+)

    diff --git a/drivers/tty/serial/8250/8250_dma.c b/drivers/tty/serial/8250/8250_dma.c
    index 6cd8a4db609a..f0fce8236279 100644
    --- a/drivers/tty/serial/8250/8250_dma.c
    +++ b/drivers/tty/serial/8250/8250_dma.c
    @@ -182,6 +182,24 @@ int serial8250_rx_dma(struct uart_8250_port *p, unsigned int iir)
    __dma_rx_do_complete(p, true);
    }
    return -ETIMEDOUT;
    + case UART_IIR_RDI:
    + if (p->bugs & UART_BUG_DMA_RX)
    + break;
    + /*
    + * The OMAP UART is a special BEAST. If we receive RDI we _have_
    + * a DMA transfer programmed but it didn't worked. One reason is
    + * that we were too slow and there were too many bytes in the
    + * FIFO, the UART counted wrong and never kicked the DMA engine
    + * to do anything. That means once we receive RDI on OMAP than
    + * the DMA won't do anything soon so we have to cancel the DMA
    + * transfer and purge the FIFO manually.
    + */
    + if (dma->rx_running) {
    + dmaengine_pause(dma->rxchan);
    + __dma_rx_do_complete(p, true);
    + }
    + return -ETIMEDOUT;
    +
    default:
    break;
    }
    --
    2.1.0


    \
     
     \ /
      Last update: 2014-09-05 21:41    [W:2.242 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site