lkml.org 
[lkml]   [2014]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] PCI: mvebu: Fix uninitialized variable in mvebu_get_tgt_attr()
Date
On Friday 05 September 2014 20:20:44 Thomas Petazzoni wrote:
> Hum, I think I would actually prefer something like:
>
> if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_IO)
> rtype = IORESOURCE_IO;
> else if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_MEM32)
> rtype = IORESOURCE_MEM;
> + else
> + continue;
>
> So that we're explicit with the fact that we only care about I/O and
> MEM32 resource types.

Agreed, that looks better than my patch as well.

Arnd


\
 
 \ /
  Last update: 2014-09-05 20:41    [W:0.046 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site