lkml.org 
[lkml]   [2014]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH RESEND v5 1/5] usb: host: ehci-st: Add EHCI support for ST STB devices
Date
On Friday 05 September 2014 18:23:45 Peter Griffin wrote:
> +struct st_platform_priv {
> + struct clk *clks[USB_MAX_CLKS];
> + struct clk *clk48;
> + struct reset_control *rst;
> + struct reset_control *pwr;
> + struct phy *phy;
> +};

Any reason why this is in a shared header file? It looks like
duplicating the structure under two different names would
actually be shorter and keep the drivers more readable as they'd
be self-contained, even when they have the exact same structure.

Do both drivers use all fields?

Arnd


\
 
 \ /
  Last update: 2014-09-05 20:41    [W:0.056 / U:15.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site