lkml.org 
[lkml]   [2014]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] perf tools: Fix build-id matching on vmlinux
From
Date
Hi Adrian and Arnaldo,

2014-09-05 (금), 11:11 -0300, Arnaldo Carvalho de Melo:
> Em Fri, Sep 05, 2014 at 10:22:40AM +0300, Adrian Hunter escreveu:
> > On 09/05/2014 07:59 AM, Namhyung Kim wrote:
> > > +++ b/tools/perf/util/machine.c
> > > @@ -1060,10 +1060,14 @@ static int machine__process_kernel_mmap_event(struct machine *machine,
> > > strlen(kmmap_prefix));
> > > /*
> > > * Should be there already, from the build-id table in
> > > - * the header.
> > > + * the header (but maybe with a different name: "vmlinux").
> > > */
> > > - struct dso *kernel = __dsos__findnew(&machine->kernel_dsos,
> > > - kmmap_prefix);
> > > + struct dso *kernel = dsos__find(&machine->kernel_dsos,
> > > + "vmlinux", true);
>
> > Isn't "vmlinux" just the basename of the original file name, so if it had a
> > different name this wouldn't work e.g. if the filename had been
> > /boot/vmlinuz-3.11.0-26-generic then you would need
> > "vmlinuz-3.11.0-26-generic" for this to work?
>
> Yeah, looking for well known pathnames to then check if the build-id
> matches the one we're looking for, be it because we obtained it from
> /sys/kernel/notes (for the running kernel), or from the perf.data file
> build-id table is ok, as we don't know where it is.
>
> Plain sticking "vmlinux" there is not.

I don't get it. AFAIK when perf record runs, it uses [kernel.kallsyms]
name for kernel map. But it can be changed only if it found a "vmlinux"
file in the vmlinux_path[]. So short name will always be "vmlinux" -
okay, it might be vmlinux-$(uname -r) too; I can add it.

As you know, the vmlinux file is a ELF image that created during kernel
build process so I guess its name is fixed. It's different from the
vmlinu"z" which resides in /boot directory.

Am I missing something?

Thanks,
Namhyung


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-09-05 17:41    [W:0.132 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site