lkml.org 
[lkml]   [2014]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] pinctrl: lantiq: Release gpiochip resources in fail case
From
On Sun, Aug 31, 2014 at 6:39 PM, Pramod Gurav
<pramod.gurav@smartplayin.com> wrote:

> This patch releases gpiochip resources with of_gpiochip_remove
> gpiochip_remove in failure cases.
>
> CC: John Crispin <blogic@openwrt.org>
> CC: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
> ---
> drivers/pinctrl/pinctrl-xway.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-xway.c b/drivers/pinctrl/pinctrl-xway.c
> index e66f4ca..d234dc2 100644
> --- a/drivers/pinctrl/pinctrl-xway.c
> +++ b/drivers/pinctrl/pinctrl-xway.c
> @@ -802,6 +802,7 @@ static int pinmux_xway_probe(struct platform_device *pdev)
> ret = gpiochip_add(&xway_chip);
> if (ret) {
> dev_err(&pdev->dev, "Failed to register gpio chip\n");
> + of_gpiochip_remove(&xway_chip);
> return ret;
> }
>
> @@ -823,6 +824,8 @@ static int pinmux_xway_probe(struct platform_device *pdev)
> ret = ltq_pinctrl_register(pdev, &xway_info);
> if (ret) {
> dev_err(&pdev->dev, "Failed to register pinctrl driver\n");
> + gpiochip_remove(&xway_chip);
> + of_gpiochip_remove(&xway_chip);

gpiochip_remove() already calls of_gpiochip_remove().

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2014-09-05 10:41    [W:0.125 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site