lkml.org 
[lkml]   [2014]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9 1/3] RTC: RK808: add RTC driver for RK808
On Wed, Sep 03, 2014 at 09:18:42PM -0700, Doug Anderson wrote:
> Chris,
>
> On Wed, Sep 3, 2014 at 6:12 PM, Chris Zhong <zyw@rock-chips.com> wrote:
> > Adding RTC driver for supporting RTC device present inside RK808 PMIC.
> >
> > Signed-off-by: Chris Zhong <zyw@rock-chips.com>
> > Signed-off-by: Zhang Qing <zhangqing@rock-chips.com>
> >
> > Tested-by: Heiko Stuebner <heiko@sntech.de>
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Doug Anderson <dianders@chromium.org>
>
>
> > + rk808_rtc->irq = platform_get_irq(pdev, 0);
> > + if (rk808_rtc->irq < 0) {
> > + dev_err(&pdev->dev, "Wake up is not possible as irq = %d\n",
> > + rk808_rtc->irq);
>
> Technically you shouldn't print the error if it's -EPROBE_DEFER.
> ...but I think that's really unlikely here (I can't imagine any real
> cases where the interrupt parent for RK808 would actually be deferred)
> so I won't push it.

Doug, platform_get_irq() simply iterates through IRQ resources assigned to the
device, which are populated at platform device creation time. The only error it
returns ever is -ENXIO, so we are fine here.

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2014-09-04 20:01    [W:0.065 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site