Messages in this thread | | | Date | Thu, 4 Sep 2014 18:27:11 +0200 | Subject | Re: [PATCH 2/3] gpio: zynq: Fixed broken wakeup implementation | From | Linus Walleij <> |
| |
On Fri, Aug 29, 2014 at 7:58 PM, Soren Brinkmann <soren.brinkmann@xilinx.com> wrote:
> From: Ezra Savard <ezra.savard@xilinx.com> > > Use of unmask/mask in set_wake was an incorrect implementation. The new > implementation correctly sets wakeup for the gpio chip's IRQ so the gpio chip > will not sleep while wakeup-enabled gpio are in use. > > Signed-off-by: Ezra Savard <ezra.savard@xilinx.com> > Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Patch applied.
However the problems seems quite generic.
Do you see this kind of error in other GPIO drivers?
IRQchip semantics always make me nervous.
Yours, Linus Walleij
| |