lkml.org 
[lkml]   [2014]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Staging: rtl8192u: fix brace style coding issue in r819xU_firmware.c
From
Date
On Thu, 2014-09-04 at 20:41 +0530, Chaitra Ramaiah wrote:
[]
> diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c b/drivers/staging/rtl8192u/r819xU_firmware.c
[]
> @@ -153,11 +153,10 @@ static bool CPUcheck_maincodeok_turnonCPU(struct net_device *dev)
> break;
> }while(check_bootOk_time--);
>
> - if (!(CPU_status&CPU_GEN_BOOT_RDY)) {
> + if (!(CPU_status&CPU_GEN_BOOT_RDY))
> goto CPUCheckMainCodeOKAndTurnOnCPU_Fail;
> - } else {
> + else
> RT_TRACE(COMP_FIRMWARE, "Download Firmware: Boot ready!\n");
> - }

This would be better as:

if (!(CPU_status & CPU_GEN_BOOT_RDY))
goto CPUCheckMainCodeOKandTurnOnCPU_Fail;

RT_TRACE(etc...)

It'd be nice to eliminate the StudlyCaps and
rather long labels too.



\
 
 \ /
  Last update: 2014-09-04 18:01    [W:0.037 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site