lkml.org 
[lkml]   [2014]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 11/12] kmemleak: use seq_hex_dump() to dump buffers
    Date
    Instead of custom approach let's use recently introduced seq_hex_dump() helper.

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    mm/kmemleak.c | 21 ++++++---------------
    1 file changed, 6 insertions(+), 15 deletions(-)

    diff --git a/mm/kmemleak.c b/mm/kmemleak.c
    index 3cda50c..bc14fdc 100644
    --- a/mm/kmemleak.c
    +++ b/mm/kmemleak.c
    @@ -291,23 +291,14 @@ static void hex_dump_object(struct seq_file *seq,
    struct kmemleak_object *object)
    {
    const u8 *ptr = (const u8 *)object->pointer;
    - int i, len, remaining;
    - unsigned char linebuf[HEX_ROW_SIZE * 5];
    + size_t len;

    /* limit the number of lines to HEX_MAX_LINES */
    - remaining = len =
    - min(object->size, (size_t)(HEX_MAX_LINES * HEX_ROW_SIZE));
    -
    - seq_printf(seq, " hex dump (first %d bytes):\n", len);
    - for (i = 0; i < len; i += HEX_ROW_SIZE) {
    - int linelen = min(remaining, HEX_ROW_SIZE);
    -
    - remaining -= HEX_ROW_SIZE;
    - hex_dump_to_buffer(ptr + i, linelen, HEX_ROW_SIZE,
    - HEX_GROUP_SIZE, linebuf, sizeof(linebuf),
    - HEX_ASCII);
    - seq_printf(seq, " %s\n", linebuf);
    - }
    + len = min(object->size, (size_t)(HEX_MAX_LINES * HEX_ROW_SIZE));
    +
    + seq_printf(seq, " hex dump (first %zu bytes):\n", len);
    + seq_hex_dump(seq, " ", DUMP_PREFIX_NONE, HEX_ROW_SIZE,
    + HEX_GROUP_SIZE, ptr, len, HEX_ASCII);
    }

    /*
    --
    2.1.0


    \
     
     \ /
      Last update: 2014-09-04 17:01    [W:6.228 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site