lkml.org 
[lkml]   [2014]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRE: [PATCH v2 4/4] clk: Use ww mutexes for clk pr epare {lock/unlock}
From
Hi Stephen,

On Wednesday, September 3, 2014 9:01pm, "Stephen Boyd" <sboyd@codeaurora.org> said:

> Changing the rate of a "slow" clock can take 10s of milliseconds
> while changing the rate of a "fast" clock can be done in a few

<snip>

> -static void clk_prepare_lock(void)
> +static void __clk_unlock(struct list_head *list)
> +{
> + struct clk *entry, *temp;
> +
> + list_for_each_entry_safe (entry, temp, list, ww_list) {

Checkpatch warning for above line,
WARNING: space prohibited between function name and open parenthesis '('

> + list_del_init(&entry->ww_list);
> + ww_mutex_unlock(&entry->lock);
> + }
> +}
> +
> +static void clk_unlock(struct list_head *list, struct ww_acquire_ctx *ctx)
> +{

<snip>

> + ww_acquire_init(ctx, &prepare_ww_class);
> + do {
> + ret = __clk_prepare_lock(clk, list, ctx);
> + } while (ret == -EDEADLK);
> + ww_acquire_done(ctx);
> +}
> +
> +static int __clk_unprepare_lock(struct clk *clk, struct list_head *list,
> + struct ww_acquire_ctx *ctx)

Checkpatch error for above line,
ERROR: code indent should use tabs where possible

Best Regards,
Kiran Padwal

> +{
> + int ret;
> +
> + do {
> + ret = clk_lock_one(clk, list, ctx);
> + if (ret == -EDEADLK)
> + return ret;
> +
> + if (clk->prepare_count > 1)
> + break;
> + } while ((clk = clk->parent));
> +
> + return 0;
> +}




\
 
 \ /
  Last update: 2014-09-04 12:41    [W:0.100 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site