lkml.org 
[lkml]   [2014]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH] xen/xen-scsiback: Need go to fail after xenbus_dev_error()
On 09/30/2014 08:32 AM, Chen Gang wrote:
> On 9/29/14 21:57, David Vrabel wrote:
>> On 29/09/14 10:59, Chen Gang wrote:
>>>
>>>
>>> If no any additional reply within 2 days, I shall send patch v2 for it:
>>>
>>> "use dev_warn() instead of xenbus_dev_error() and remove 'fail' code block"
>>
>> I think this driver is fine as-is and does not need any changes.
>>
>
> OK, at least, at present, it is not a bug (will cause any issue).
>
> But for me, xenbus_dev_error() seems for printing generic errors,
> dev_warn() is more suitable than it.

I'm unbiased regarding this one.

>
> And 'fail' code block is useless now, need be removed, too (which will
> let compiler report warning).

This should be part of the patch making the 'fail' block useless.


Juergen



\
 
 \ /
  Last update: 2014-09-30 09:01    [W:0.061 / U:1.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site