lkml.org 
[lkml]   [2014]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13 102/103] KEYS: Fix use-after-free in assoc_array_gc()
    Date
    3.13.11.8 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: David Howells <dhowells@redhat.com>

    commit 27419604f51a97d497853f14142c1059d46eb597 upstream.

    An edit script should be considered inaccessible by a function once it has
    called assoc_array_apply_edit() or assoc_array_cancel_edit().

    However, assoc_array_gc() is accessing the edit script just after the
    gc_complete: label.

    Reported-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
    Signed-off-by: David Howells <dhowells@redhat.com>
    Reviewed-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
    cc: shemming@brocade.com
    cc: paulmck@linux.vnet.ibm.com
    Signed-off-by: James Morris <james.l.morris@oracle.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    lib/assoc_array.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/lib/assoc_array.c b/lib/assoc_array.c
    index 76ae279..f9524b8 100644
    --- a/lib/assoc_array.c
    +++ b/lib/assoc_array.c
    @@ -1737,7 +1737,7 @@ ascend_old_tree:
    gc_complete:
    edit->set[0].to = new_root;
    assoc_array_apply_edit(edit);
    - edit->array->nr_leaves_on_tree = nr_leaves_on_tree;
    + array->nr_leaves_on_tree = nr_leaves_on_tree;
    return 0;

    enomem:
    --
    1.9.1


    \
     
     \ /
      Last update: 2014-10-01 00:21    [W:3.111 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site