lkml.org 
[lkml]   [2014]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] regmap: Allow read_reg_mask to be 0
    On 09/30/2014 06:07 PM, Dan Murphy wrote:
    > There may be spi devices that do not require a
    > register read mask to read the registers.
    >
    > Currently the code sets the read mask based on
    > a non-zero value passed in from the driver or if that
    > value is 0 sets the read mask to 0x80.

    It only sets it to the bus default if both read_flag_mask and
    write_flag_mask are 0. The assumption is that both of them being zero is a
    invalid configuration and either of them (or both) have to be non-zero for
    proper operation, since otherwise the device can't tell the difference
    between a read and a write.

    Do you have a device where both the read and the write mask is 0?

    - Lars


    \
     
     \ /
      Last update: 2014-09-30 23:41    [W:4.698 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site