Messages in this thread | | | Date | Tue, 30 Sep 2014 07:15:06 -0700 | From | Bjorn Andersson <> | Subject | Re: [RFC 4/7] soc: qcom: Add Shared Memory Manager driver |
| |
On Mon 29 Sep 23:28 PDT 2014, Kiran Padwal wrote:
> > Hi, > > On Tuesday 30 September 2014 11:47 AM, Kiran Padwal wrote: > > Hi Bjorn, > > > > On Tuesday 30 September 2014 06:04 AM, Bjorn Andersson wrote: [..] > >> + smem->hwlock = of_hwspin_lock_request(pdev->dev.of_node, NULL); > > > > Compilation breaks while I try to compile with this patch. > > Do I missing anything? Below is the error I am getting, > > > > drivers/soc/qcom/qcom_smem.c: In function ‘qcom_smem_probe’: > > drivers/soc/qcom/qcom_smem.c:274:2: error: implicit declaration of function ‘of_hwspin_lock_request’ [-Werror=implicit-function-declaration] > > smem->hwlock = of_hwspin_lock_request(pdev->dev.of_node, NULL) > > I am sorry I missed the note in commit message of this patch. I did look for any such note in cover letter > and also googled around for any change to find this function. > Could not find and hence posted comment. Please ignore. >
I respun this ontop of Suman Anna's latest hwspinlock patches [1] and [2].
The above code should now be:
hwlock_id = of_hwspin_lock_get_id(pdev->dev.of_node, 0); smem->hwlock = hwspin_lock_request_specific(hwlock_id);
Will include this in the next spin.
[1] https://patchwork.kernel.org/patch/4898051/ [2] https://patchwork.kernel.org/patch/4898071/
Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |