lkml.org 
[lkml]   [2014]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 64/88] Btrfs: fix compressed write corruption on enospc
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Liu Bo <bo.li.liu@oracle.com>

    commit ce62003f690dff38d3164a632ec69efa15c32cbf upstream.

    When failing to allocate space for the whole compressed extent, we'll
    fallback to uncompressed IO, but we've forgotten to redirty the pages
    which belong to this compressed extent, and these 'clean' pages will
    simply skip 'submit' part and go to endio directly, at last we got data
    corruption as we write nothing.

    Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
    Tested-By: Martin Steigerwald <martin@lichtvoll.de>
    Signed-off-by: Chris Mason <clm@fb.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/btrfs/inode.c | 12 ++++++++++++
    1 file changed, 12 insertions(+)

    --- a/fs/btrfs/inode.c
    +++ b/fs/btrfs/inode.c
    @@ -701,6 +701,18 @@ retry:
    unlock_extent(io_tree, async_extent->start,
    async_extent->start +
    async_extent->ram_size - 1);
    +
    + /*
    + * we need to redirty the pages if we decide to
    + * fallback to uncompressed IO, otherwise we
    + * will not submit these pages down to lower
    + * layers.
    + */
    + extent_range_redirty_for_io(inode,
    + async_extent->start,
    + async_extent->start +
    + async_extent->ram_size - 1);
    +
    goto retry;
    }
    goto out_free;



    \
     
     \ /
      Last update: 2014-09-04 00:41    [W:4.420 / U:0.636 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site