lkml.org 
[lkml]   [2014]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/6] staging: goldfish: document spinlock usage
On Wed, Sep 03, 2014 at 01:13:19PM +0100, One Thousand Gnomes wrote:
>
> This tells the reader nothing. It's good to document locking models but
>
> - you lock data not code (which is a detail a lot of programmers get wrong
> in th design stage too)
> - you need to document what objects are protected by the lock
>
>
> So it should tell the reader what the lock must be held to do
>
> If you look at the audio code it actually protects the status field and
> status register of the "hardware"

Hello,

Thank you for the feedback, I will send a v2.

--
Cheers,
Loïc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-09-03 19:01    [W:0.049 / U:1.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site