Messages in this thread | | | Date | Wed, 3 Sep 2014 17:30:11 +0200 | From | Peter Zijlstra <> | Subject | Re: [QUERY] Confusing usage of rq->nr_running in load balancing |
| |
On Wed, Sep 03, 2014 at 05:51:45PM +0530, Preeti U Murthy wrote: > Hi, > > There are places in kernel/sched/fair.c in the load balancing part where > rq->nr_running is used as against cfs_rq->nr_running. At least I could
> Did I miss something or is it true that the usage of rq->nr_running in > the above places is incorrect?
Yeah, smells fishy. Probably hysterical accidents that haven't been cleaned up yet. I do remember a few patches cleaning some of this up recently. Clearly there's more to do.
| |