Messages in this thread | | | Date | Wed, 3 Sep 2014 12:59:50 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v4] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert |
| |
On Wed, Sep 03, 2014 at 02:59:21PM +0530, Sudip Mukherjee wrote: > 1) removed unused variables > 2) fixed sparse warning of context imbalance in 'do_locked_client_insert' > different lock contexts for basic block > 3) removed the call to visor_signalqueue_empty() , this function is > checking whether a signal queue is empty, but the return value > of the function is not beeing used, so it is safe to remove. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Looks good. Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
| |