lkml.org 
[lkml]   [2014]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 33/56] hwmon: (gpio-fan) Prevent overflow problem when writing large limits
    Date
    From: Axel Lin <axel.lin@ingics.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 2565fb05d1e9fc0831f7b1c083bcfcb1cba1f020 upstream.

    On platforms with sizeof(int) < sizeof(unsigned long), writing a rpm value
    larger than MAXINT will result in unpredictable limit values written to the
    chip. Avoid auto-conversion from unsigned long to int to fix the problem.

    Signed-off-by: Axel Lin <axel.lin@ingics.com>
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    drivers/hwmon/gpio-fan.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c
    index b7d6a5704eb2..ee21bdd610ee 100644
    --- a/drivers/hwmon/gpio-fan.c
    +++ b/drivers/hwmon/gpio-fan.c
    @@ -172,7 +172,7 @@ static int get_fan_speed_index(struct gpio_fan_data *fan_data)
    return -EINVAL;
    }

    -static int rpm_to_speed_index(struct gpio_fan_data *fan_data, int rpm)
    +static int rpm_to_speed_index(struct gpio_fan_data *fan_data, unsigned long rpm)
    {
    struct gpio_fan_speed *speed = fan_data->speed;
    int i;
    --
    2.1.0


    \
     
     \ /
      Last update: 2014-09-03 12:41    [W:4.063 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site