lkml.org 
[lkml]   [2014]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 4/5] Clocksource: Flextimer: Fix counter clock prescaler calculation.
Date
Hi Thomas,

Thanks very much for your comments.

Firstly I must tell the true that English is not my mother language.


> Subject: Re: [PATCH 4/5] Clocksource: Flextimer: Fix counter clock prescaler
> calculation.
>
> On Tue, 26 Aug 2014, Xiubo Li wrote:
>
> > We should minus one after calculating the counter input clock's
> > prescaler.
>
> And that's a complete useless changelog.
>
> A) It lacks a proper description of the problem
>
> B) It lacks a proper argument WHY we must decrement the prescaler
> value
>
> Hint: I used the verb "must" instead of "should". Can you figure
> out why?
>

Yes, we should use 'must' here, because we are using 'ps++' in the loop code,
the correct value should be 'ps = ps - 1', after the loop.

BRs
Xiubo


\
 
 \ /
  Last update: 2014-09-04 04:21    [W:0.156 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site