Messages in this thread Patch in this message | | | From | Philipp Zabel <> | Subject | [PATCH v4 1/8] [media] soc_camera: Do not decrement endpoint node refcount in the loop | Date | Mon, 29 Sep 2014 10:15:44 +0200 |
| |
In preparation for a following patch, stop decrementing the endpoint node refcount in the loop. This temporarily leaks a reference to the endpoint node, which will be fixed by having of_graph_get_next_endpoint decrement the refcount of its prev argument instead.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> --- Changes since v3: - Moved of_node_put for the break case after the loop --- drivers/media/platform/soc_camera/soc_camera.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform/soc_camera/soc_camera.c index f4308fe..619b2d4 100644 --- a/drivers/media/platform/soc_camera/soc_camera.c +++ b/drivers/media/platform/soc_camera/soc_camera.c @@ -1696,7 +1696,6 @@ static void scan_of_host(struct soc_camera_host *ici) if (!i) soc_of_bind(ici, epn, ren->parent); - of_node_put(epn); of_node_put(ren); if (i) { @@ -1704,6 +1703,8 @@ static void scan_of_host(struct soc_camera_host *ici) break; } } + + of_node_put(epn); } #else -- 2.1.0
| |