lkml.org 
[lkml]   [2014]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 6/8] phy: miphy28lp: Add SSC support for PCIE
From
Date
On Fri, 26 Sep 2014 10:54:15 +0200, Gabriel FERNANDEZ said:
> SSC is the technique of modulating the operating frequency of a signal
> slightly to spread its radiated emissions over a range of frequencies.
> This reduction in the maximum emission for a given frequency helps meet
> radiated emission requirements.
> These settings are applicable for PCIE with Internal clock.

> + writeb_relaxed(0x69, miphy_phy->base + MIPHY_PLL_SBR_3);
> + writeb_relaxed(0x21, miphy_phy->base + MIPHY_PLL_SBR_4);
> + writeb_relaxed(0x3c, miphy_phy->base + MIPHY_PLL_SBR_2);
> + writeb_relaxed(0x21, miphy_phy->base + MIPHY_PLL_SBR_4);
> + writeb_relaxed(0x00, miphy_phy->base + MIPHY_PLL_SBR_1);
> + writeb_relaxed(0x02, miphy_phy->base + MIPHY_PLL_SBR_1);
> + writeb_relaxed(0x00, miphy_phy->base + MIPHY_PLL_SBR_1);

I'd feel a lot better about all these magic numbers (and the triple write
to SBR_1) if the Changelog or something referenced where they came from....
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-09-29 22:01    [W:0.118 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site