Messages in this thread | | | Date | Mon, 29 Sep 2014 10:54:59 -0700 | Subject | Re: [PATCH v2] vfs: Don't exchange "short" filenames unconditionally. | From | Linus Torvalds <> |
| |
On Mon, Sep 29, 2014 at 9:27 AM, Al Viro <viro@zeniv.linux.org.uk> wrote: > > What we get in free_dentry() is: > * external name not shared: refcount driven to 0, RCU-delayed > call of "free dentry, free ext name" > * external name still shared: refcount positive after decrement, > no freeing ext name > * no external name: no ext name to free > In the last two cases we do what dentry_free() used to do, except that now > __d_free() doesn't even look for ext name. Just frees the dentry. If > it never had been hashed - directly called, otherwise - via call_rcu(). > > Does that look OK for you?
Yes. That looks fairly straightforward.
Although please rename that "ext" in ext_name/__d_free_ext() to something else. "ext" to me says not "external", but "extended". I think we can just write out "external", like we already do in "dname_external()".
Linus
| |