Messages in this thread | | | Subject | Re: [PATCH v7] checkkconfigsymbols.sh: reimplementation in python | From | Paul Bolle <> | Date | Mon, 29 Sep 2014 18:21:42 +0200 |
| |
Hi Michal,
[This point I already conceded to Valentin, so my remarks are moot for Valentin's script.]
On Mon, 2014-09-29 at 16:47 +0200, Michal Marek wrote: > On 2014-09-29 12:28, Paul Bolle wrote: > >> +STMT = r"^\s*(?:if|select|depends\s+on)\s+" + EXPR > > > > Could please make that "depends on"? Yes, it seems the yacc grammar > > accepts any amount of whitespace, but that doesn't make it right to use > > anything other than a single space. > > But then lines that violate coding style would not be checked for real > errors.
Perhaps my dislike of this element of the grammar won here. There are probably better ways to enforce proper use of "depends on".
> > (Can the yacc grammar be tweaked to > > see "depends on" as one, well, token?) > > I don't think this is a good idea. This is a style issue, why make it a > grammar issue.
Well, a grammar that allows one of its keywords to be written in different ways makes style and grammar issues overlap. Whatever. I guess it's just me being annoyed with writing git grep -w "depends\s\+on\s\+FOO"
instead of git grep -w "depends on FOO"
Ditto for writing a parser for Kconfig files. (Real world examples are more complicated, but you catch my drift.)
Paul Bolle
| |