Messages in this thread | | | Date | Mon, 29 Sep 2014 12:11:25 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() |
| |
On Mon, 29 Sep 2014 08:46:50 -0700 Joe Perches <joe@perches.com> wrote:
> On Mon, 2014-09-29 at 11:25 -0400, Steven Rostedt wrote: > > Anyway, that should be a second patch, and we should get my current > > patch (the one to make putc and puts the same) in first, as that > > actually fixes the inconsistency between the two. > > > > I'll post another patch to try to make seq_file operations a bit more > > consistent. Perhaps we can have m->count be what would have been > > written. > > https://lkml.org/lkml/2013/9/11/801 >
That has nothing to do with what I'm working on. I'm not touching the return value of the seq_*() functions. I may make them all return void though.
I may just make m->count == m->size + 1 for all cases. The m->count == what would have been written is if seq_buf() needs it. Which I highly doubt it would.
-- Steve
| |