Messages in this thread | | | Date | Mon, 29 Sep 2014 16:41:39 +0200 | From | Michal Marek <> | Subject | Re: [PATCH 1/1] [RFC] kconfig: warn if an unknown symbol is selected |
| |
On 2014-09-27 00:08, Paul Bolle wrote: > A select of an unknown symbol is basically treated as a nop and is > silently skipped. This is annoying if the selected symbol contains a > typo. It can also hide the fact that a treewide symbol cleanup was only > done partially. > > There are also a few cases were this might have been done on purpose. > But that anti-pattern should be discouraged. Almost all select > statements point to a known and reachable symbol. So people will likely > assume that any selected symbol is actually set. Violating that > assumption might lead to (subtle) bugs. > > So let's warn when we notice a select of a symbol that is not known in > the configuration we're creating. > > Rfced-by: Paul Bolle <pebolle@tiscali.nl>
I think this is a good idea, it fits well next to the already present warning about selecting symbols with unmet dependencies. Feel free to submit as a regular patch with
Acked-by: Michal Marek <mmarek@suse.cz>
Michal
| |