Messages in this thread | | | Date | Mon, 29 Sep 2014 15:47:18 +0200 | From | Patrice Chotard <> | Subject | Re: [PATCH] pinctrl: st: Fix Sparse error |
| |
Hi Pramod
On 09/29/2014 03:48 PM, Pramod Gurav wrote: > This change fixes below sparse error, > drivers/pinctrl/pinctrl-st.c:1515:31: error: incompatible types for operation (>) > drivers/pinctrl/pinctrl-st.c:1515:31: left side has type void [noderef] <asn:2>*irqmux_base > drivers/pinctrl/pinctrl-st.c:1515:31: right side has type int > > The fix is done by removing a check on info->irqmux_base as > info->irqmux_base has already been checked for error when allocating it. > Hence there is no need to redo the check. > > Cc: Maxime Coquelin <maxime.coquelin@st.com> > Cc: Patrice Chotard <patrice.chotard@st.com> > CC: Linus Walleij <linus.walleij@linaro.org> > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com> > --- > drivers/pinctrl/pinctrl-st.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index 5475374..ddeaeda 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -1512,7 +1512,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info, > gpio_irq, st_gpio_irq_handler); > } > > - if (info->irqmux_base > 0 || gpio_irq > 0) { > + if (gpio_irq > 0) { > err = gpiochip_irqchip_add(&bank->gpio_chip, &st_gpio_irqchip, > 0, handle_simple_irq, > IRQ_TYPE_LEVEL_LOW);
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
| |