lkml.org 
[lkml]   [2014]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mtd: ubi: Extend UBI layer debug/messaging capabilities
On 9/28/2014 11:01 AM, Richard Weinberger wrote:
> Tanya,
>
> Am 28.09.2014 08:36, schrieb Tanya Brokhman:
>> If there is more then one UBI device mounted, there is no way to
>> distinguish between messages from different UBI devices.
>> Add device number to all ubi layer message types.
>>
>>
>> Signed-off-by: Tanya Brokhman <tlinder@codeaurora.org>
>
> Artem's mail is dedekind1@ not dedeking1@. :)

oops.... sorry about that. thanks for the fix.

> Anyway, instead of passing ubi->ubi_num down to every log function you can
> just pass the ubi object itself and let the log function access ->ubi_num.

This is how I first implemented this patch. But then I cam across some
ubi_err prints during the init process (in build.c ubi_init()) when we
still don't have the ubi structure, so we need to pass some number to
the message. I overcame this by using UBI_MAX_DEVICES.


--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation


\
 
 \ /
  Last update: 2014-09-28 10:41    [W:0.103 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site