Messages in this thread | | | Date | Sat, 27 Sep 2014 15:53:56 -0700 | From | Behan Webster <> | Subject | Re: [PATCH 1/2] arm, fbdev, omap2, LLVMLinux: Remove nested function from omap2 dss |
| |
On 09/27/14 09:46, Felipe Balbi wrote: > On Fri, Sep 26, 2014 at 06:10:52PM -0700, Behan Webster wrote: >> Replace the use of nested functions where a normal function will suffice. >> >> Nested functions are not liked by upstream kernel developers in general. Their >> use breaks the use of clang as a compiler, and doesn't make the code any >> better. >> >> This code now works for both gcc and clang. >> >> Signed-off-by: Behan Webster <behanw@converseincode.com> >> Suggested-by: Arnd Bergmann <arnd@arndb.de> >> Cc: Arnd Bergmann <arnd@arndb.de> > another one that make sense :-) And probably also deserves > checkpatch/coccinelle/sparse. Indeed! That would be very appreciated.
The clang static analyzer already points this one out. :)
Behan
-- Behan Webster behanw@converseincode.com
| |