Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v2 1/3] drivers: of: add return value to of_reserved_mem_device_init | Date | Fri, 26 Sep 2014 22:13:31 +0200 |
| |
On Thursday 11 September 2014, Marek Szyprowski wrote: > -void of_reserved_mem_device_init(struct device *dev) > +int of_reserved_mem_device_init(struct device *dev) > { > struct reserved_mem *rmem; > struct device_node *np; > @@ -260,6 +260,7 @@ void of_reserved_mem_device_init(struct device *dev) > > rmem->ops->device_init(rmem, dev); > dev_info(dev, "assigned reserved memory node %s\n", rmem->name); > + return 0; > }
This function has two other 'return' statements that now are missing a return value for the error case and cause undefined behavior in the caller.
Arnd
| |