Messages in this thread | | | Date | Fri, 26 Sep 2014 12:35:53 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 1/2] perf callchain: Create an address space per thread |
| |
Em Tue, Sep 23, 2014 at 09:49:22PM +0900, Namhyung Kim escreveu: > On Tue, Sep 23, 2014 at 9:24 PM, Jiri Olsa <jolsa@redhat.com> wrote: > >> list_add(&comm->list, &thread->comm_list); > >> + > >> + if (unwind__prepare_access(thread) < 0) { > > > > you could call list_add below this call and thus save > > the list_del call below in error path > > > > looks like you dont need comm to be on comm_list within > > the unwind__prepare_access call > > Right. Will change.
Ok, waiting for v2 then.
- Arnaldo
| |