Messages in this thread | | | From | bpqw <> | Subject | RE: [PATCH 1/1] driver:mtd:spi-nor: Add Micron quad I/O support | Date | Fri, 26 Sep 2014 08:39:38 +0000 |
| |
>> + /* set EVCR ,enable quad I/O */ >> + nor->cmd_buf[0] = val & ~EVCR_QUAD_EN_MICRON; >> + ret = nor->write_reg(nor, SPINOR_OP_WD_EVCR, nor->cmd_buf, 1, 0); >> + if (ret < 0) { >> + dev_err(nor->dev, >> + "error while writing EVCR register\n"); >> + return -EINVAL; >> + } >> + >> + if (wait_till_ready(nor)) >> + return 1;
>Why does this not return proper error code or even better, return value from >wait_till_ready() ? > >Other than that, there's nothing wrong with the patch I think.
Hi,Marek Thanks for your review,you can find the same usage in the spi-nor.c. Below method is OK? Or you can give me some suggestion.
if (wait_till_ready(nor)) return - EINVAL;
| |