| Date | Thu, 25 Sep 2014 09:19:20 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH v2 03/22] MSI: Remove the redundant irq_set_chip_data() |
| |
On Thu, Sep 25, 2014 at 11:14:13AM +0800, Yijing Wang wrote: > Currently, pcie-designware, pcie-rcar, pci-tegra drivers > use irq chip_data to save the msi_chip pointer. They > already call irq_set_chip_data() in their own MSI irq map > functions. So irq_set_chip_data() in arch_setup_msi_irq() > is useless.
Again, I think this should be the other way around. If drivers do something that's already handled by the core, then the duplicate code should be dropped from the drivers.
Thierry [unhandled content-type:application/pgp-signature] |