Messages in this thread | | | Date | Wed, 24 Sep 2014 11:31:24 -0700 | Subject | Re: linux-next: cgroup_mount() falls asleep forever | From | Cong Wang <> |
| |
On Wed, Sep 24, 2014 at 7:29 AM, Andrey Wagin <avagin@gmail.com> wrote: > 2014-09-24 14:31 GMT+04:00 Andrey Wagin <avagin@gmail.com>: >> Hi All, > > The problem is in a following commit: > > commit 0c7bf3e8cab7900e17ce7f97104c39927d835469 > Author: Zefan Li <lizefan@huawei.com> > Date: Sat Sep 20 14:49:10 2014 +0800 > > cgroup: remove redundant variable in cgroup_mount() > > Both pinned_sb and new_sb indicate if a new superblock is needed, > so we can just remove new_sb. > > Note now we must check if kernfs_tryget_sb() returns NULL, because > when it returns NULL, kernfs_mount() may still re-use an existing > superblock, which is just allocated by another concurent mount. >
I guess the check for NULL is incorrect, the comment on kernfs_pin_sb() says:
Returns NULL if there's no superblock associated to this kernfs_root,
| |