lkml.org 
[lkml]   [2014]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [RFC PATCH] usb: core: log more general message on malformed LANGID descriptor
On Tue, 23 Sep 2014, Greg Kroah-Hartman wrote:

> On Tue, Sep 23, 2014 at 10:28:49PM +0000, Scot Doyle wrote:
>> I'd like to change this error message:
>> [ 3.325837] usb 1-4: string descriptor 0 malformed (err = -61), defaulting to 0x0409
>>
>> into an error message followed by a debug message:
>> [ 3.324726] usb 1-4: malformed string descriptor; unknown language, defaulting to English
>> [ 3.327514] usb 1-4: string descriptor 0 malformed (err = -61), defaulting to 0x0409
>>
>> in order to communicate more information from the log itself. Are there
>> any problems with this approach? Would it be better to put all the
>> information on a single line? Something else?
>
> How about just one line, why two?
>
> And something like "device not implementing langid specifier, defaulting
> to English", but cleaned up to sound a bit better?

That sounds good, I plan to submit this patch tomorrow unless anyone
prefers different wording.

---
diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
index 0c8a7fc..5317081 100644
--- a/drivers/usb/core/message.c
+++ b/drivers/usb/core/message.c
@@ -770,9 +770,7 @@ static int usb_get_langid(struct usb_device *dev, unsigned char *tbuf)
dev->string_langid = 0x0409;
dev->have_langid = 1;
dev_err(&dev->dev,
- "string descriptor 0 malformed (err = %d), "
- "defaulting to 0x%04x\n",
- err, dev->string_langid);
+ "language id specifier not provided by device, defaulting to English");
return 0;
}


\
 
 \ /
  Last update: 2014-09-24 20:01    [W:0.061 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site