Messages in this thread | | | Date | Wed, 24 Sep 2014 23:01:00 +0800 | Subject | Re: [PATCH v4 09/10] blk-mq: handle failure path for initializing hctx | From | Ming Lei <> |
| |
On Wed, Sep 24, 2014 at 10:17 PM, Jens Axboe <axboe@kernel.dk> wrote: > On 09/24/2014 04:22 AM, Christoph Hellwig wrote: >> On Mon, Sep 15, 2014 at 09:11:13PM +0800, Ming Lei wrote: >>> Failure of initializing one hctx isn't handled, so this patch >>> introduces blk_mq_init_hctx() and its pair to handle it explicitly. >>> Also this patch makes code cleaner. >>> >>> Signed-off-by: Ming Lei <ming.lei@canonical.com> >> >> Looks good, >> >> Reviewed-by: Christoph Hellwig <hch@lst.de> >> >> Shouldn't this go to Jens as a separate fix for 3.18? > > I think so, doesn't look like it's tied into the series at all.
Without this one, patch 10 becomes quite ugly.
OK, I will split this one from this patchset.
Thank,
| |