lkml.org 
[lkml]   [2014]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 09/10] blk-mq: handle failure path for initializing hctx
From
On Wed, Sep 24, 2014 at 10:17 PM, Jens Axboe <axboe@kernel.dk> wrote:
> On 09/24/2014 04:22 AM, Christoph Hellwig wrote:
>> On Mon, Sep 15, 2014 at 09:11:13PM +0800, Ming Lei wrote:
>>> Failure of initializing one hctx isn't handled, so this patch
>>> introduces blk_mq_init_hctx() and its pair to handle it explicitly.
>>> Also this patch makes code cleaner.
>>>
>>> Signed-off-by: Ming Lei <ming.lei@canonical.com>
>>
>> Looks good,
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>>
>> Shouldn't this go to Jens as a separate fix for 3.18?
>
> I think so, doesn't look like it's tied into the series at all.

Without this one, patch 10 becomes quite ugly.

OK, I will split this one from this patchset.

Thank,


\
 
 \ /
  Last update: 2014-09-24 17:41    [W:1.375 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site