lkml.org 
[lkml]   [2014]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] of: fdt: fix memory range check


On 24/09/14 15:38, Grant Likely wrote:
>> --- a/drivers/of/fdt.c
>> >+++ b/drivers/of/fdt.c
>> >@@ -937,7 +937,7 @@ void __init __weak early_init_dt_add_memory_arch(u64 base, u64 size)
>> > return;
>> > }
>> >
>> >- if (base + size > MAX_PHYS_ADDR) {
>> >+ if (base + size - 1 > MAX_PHYS_ADDR) {
>> > pr_warning("Ignoring memory range 0x%lx - 0x%llx\n",
>> > ULONG_MAX, base + size);
>> > size = MAX_PHYS_ADDR - base;
> By that logic, the above two lines need to be repaired also:
Thanks for fixing this too.
>
> pr_warning("Ignoring memory range 0x%lx - 0x%llx\n",
> MAX_PHYS_ADDR + 1, base + size);

I think the first argument should be printed in 0x%llx format as there
would be a 32bit overflow for MAX_PHYS_ADDR + 1.

> size = MAX_PHYS_ADDR - base + 1;
>
> I've fixed it up and applied, thanks.

--srini


\
 
 \ /
  Last update: 2014-09-24 17:21    [W:0.217 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site