lkml.org 
[lkml]   [2014]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC PATCH v2 07/16] gpio: Add support for unified device properties interface
    Date
    On Wednesday, September 24, 2014 12:38:23 PM Mika Westerberg wrote:
    > On Wed, Sep 24, 2014 at 11:12:36AM +0200, Arnd Bergmann wrote:
    > > As a start, we could probably take the proposed device_for_each_child_node
    > > and move that into the leds-core, changing the fw_dev_node argument
    > > for an led_classdev with the addition of the of_node and acpi_object
    > > members. It would still leave it up to the gpio-leds driver to do
    > >
    > > if (led_cdev->of_node)
    > > gpiod = devm_of_get_gpiod(led_cdev->of_node, ...);
    > > else
    > > gpiod = devm_acpi_get_gpiod(led_cdev->acpi_object, ...);
    > >
    > > but there seems little benefit in abstracting this because there is
    > > only one driver that needs it.
    >
    > The same interface is used also in gpio_keys_polled.c driver so if we
    > want to avoid duplicating code this needs to be abstracted away from the
    > drivers.

    Well, precisely.

    Moving it to the leds-core doesn't buy us anything.

    --
    I speak only for myself.
    Rafael J. Wysocki, Intel Open Source Technology Center.


    \
     
     \ /
      Last update: 2014-09-24 16:21    [W:3.252 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site