Messages in this thread | | | Date | Wed, 24 Sep 2014 15:13:02 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH V5 02/16] perf, core: introduce pmu context switch callback |
| |
On Wed, Sep 10, 2014 at 10:08:59AM -0400, kan.liang@intel.com wrote: > @@ -2446,6 +2499,9 @@ void __perf_event_task_sched_out(struct task_struct *task, > { > int ctxn; > > + if (__get_cpu_var(perf_sched_cb_usages)) > + perf_pmu_sched_task(task, next, false); > + > for_each_task_context_nr(ctxn) > perf_event_context_sched_out(task, ctxn, next); > > @@ -2703,6 +2759,9 @@ void __perf_event_task_sched_in(struct task_struct *prev, > /* check for system-wide branch_stack events */ > if (atomic_read(&__get_cpu_var(perf_branch_stack_events))) > perf_branch_stack_sched_in(prev, task); > + > + if (__get_cpu_var(perf_sched_cb_usages)) > + perf_pmu_sched_task(prev, task, true); > } >
I think the general idea was to get rid of __get_cpu_var() and co, please consider using __this_cpu_read().
| |