Messages in this thread | | | From | Mike Turquette <> | Date | Tue, 2 Sep 2014 15:00:17 -0700 | Subject | Re: [PATCH 3/3] cpufreq: kirkwood: use the powersave multiplexer |
| |
On Mon, Sep 1, 2014 at 9:49 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > On 2 September 2014 00:17, Mike Turquette <mturquette@linaro.org> wrote: > >> @@ -150,7 +146,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev) >> err = PTR_ERR(priv.powersave_clk); >> goto out_ddr; >> } >> - clk_prepare(priv.powersave_clk); >> + clk_prepare_enable(priv.powersave_clk); > > Shouldn't this be done in a separate patch? Or is this really related?
It is related. Before this change powersave_clk was modeled as a gate. The separate clk_enable/clk_disable operations were used to toggle the mux. This patch does two things:
1) remove the old gate-style powersave_clk in the clock driver and replace with the mux-style powersave_clk data 2) update the cpufreq driver to handle the mux properly
So the change you pointed out above is part of #2.
These two changes are coupled in one patch to prevent git bisect breakage.
> >> >> of_node_put(np); >> np = NULL; > > Other than that: Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > > Yeah, you can take it through clock tree..
Cool.
Thanks, Mike
| |