Messages in this thread | | | Date | Tue, 2 Sep 2014 13:13:47 -0400 | Subject | Re: [PATCH] Revert "leds: convert blink timer to workqueue" | From | Josh Boyer <> |
| |
On Tue, Sep 2, 2014 at 1:02 PM, Bryan Wu <cooloney@gmail.com> wrote: > On Tue, Sep 2, 2014 at 2:03 AM, Jiri Kosina <jkosina@suse.cz> wrote: >> This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. >> >> It's broken as it changes led_blink_set() in a way that it can now sleep >> (while synchronously waiting for workqueue to be cancelled). That's a >> problem, because it's possible that this function gets called from atomic >> context (tpt_trig_timer() takes a readlock and thus disables preemption). >> >> This has been brought up 3 weeks ago already [1] but no proper fix has >> materialized, and I keep seeing the problem since 3.18-rc1. >> > > Is this 3.18-rc1? I think it should be 3.17-rc1, right?
Yes . josh
| |