Messages in this thread | | | Date | Tue, 2 Sep 2014 08:24:37 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v7 2/5] MFD: RK808: Add new mfd driver for RK808 |
| |
On Mon, 01 Sep 2014, Doug Anderson wrote: > On Mon, Sep 1, 2014 at 3:09 AM, Lee Jones <lee.jones@linaro.org> wrote: > > On Mon, 01 Sep 2014, Chris Zhong wrote: > > > >> The RK808 chip is a power management IC for multimedia and handheld > >> devices. It contains the following components: > >> > >> - Regulators > >> - RTC > >> - Clkout > >> > >> The RK808 core driver is registered as a platform driver and provides > >> communication through I2C with the host device for the different > >> components. > >> > >> Signed-off-by: Chris Zhong <zyw@rock-chips.com> > >> Signed-off-by: Zhang Qing <zhangqing@rock-chips.com> > > > > Couple of nits. Once fixed you can apply my: > > > > Acked-by: Lee Jones <lee.jones@linaro.org> > > > > [...] > > > >> +/* > >> + * MFD core driver for Rockchip RK808 > >> + * > >> + * Copyright (c) 2014, Fuzhou Rockchip Electronics Co., Ltd > > > > Author? > > I asked Chris to remove the author in my response to an earlier > version since it's at the bottom (MODULE_AUTHOR) and it seems extra > duplication. You are the boss though, so if it should go both places > then Chris should add this back. Sorry for the bad advice, Chris.
Yes, both places please. They do different things.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |