lkml.org 
[lkml]   [2014]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] drivers/bus: Freescale Management Complex bus driver patch series

On 09/18/2014 07:58 AM, Alexander Graf wrote:

>>
>>> checkpatch:
>>>
>>> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
>>>
>>> WARNING: DT compatible string "fsl,qoriq-mc" appears un-documented -- check ./Documentation/devicetree/bindings/
>>> #690: FILE: drivers/bus/fsl-mc/fsl_mc_bus.c:528:
>>> + {.compatible = "fsl,qoriq-mc",},
>>>
>>> For the former warning, I'd suggest moving patch 4/4's contents up
>>> in the series.
>> I tried moving 4/4 to be 1/4 but still get the the same warning from checkpatch. So, this suggestion does not work. Besides, I took a look
>> at other commits that update the MAINTAINERS such as
>> 563da3a90364fc29cd09bed034162592e591747a, and that commit comes after the commits that added the new files.
>
> The alternative would be to add MAINTAINERS entries for the files you add in the patch that adds the files.
>
I tried this but still get the checpatch warning:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

Still, I will add MAINTAINERS entries in each patch that adds files,
instead of having a separate patch just for that.

>
> Alex
>


\
 
 \ /
  Last update: 2014-09-19 03:21    [W:0.080 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site