Messages in this thread | | | Date | Thu, 18 Sep 2014 19:31:03 -0500 | From | German Rivera <> | Subject | Re: [PATCH 0/4] drivers/bus: Freescale Management Complex bus driver patch series |
| |
On 09/18/2014 07:58 AM, Alexander Graf wrote:
>> >>> checkpatch: >>> >>> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? >>> >>> WARNING: DT compatible string "fsl,qoriq-mc" appears un-documented -- check ./Documentation/devicetree/bindings/ >>> #690: FILE: drivers/bus/fsl-mc/fsl_mc_bus.c:528: >>> + {.compatible = "fsl,qoriq-mc",}, >>> >>> For the former warning, I'd suggest moving patch 4/4's contents up >>> in the series. >> I tried moving 4/4 to be 1/4 but still get the the same warning from checkpatch. So, this suggestion does not work. Besides, I took a look >> at other commits that update the MAINTAINERS such as >> 563da3a90364fc29cd09bed034162592e591747a, and that commit comes after the commits that added the new files. > > The alternative would be to add MAINTAINERS entries for the files you add in the patch that adds the files. > I tried this but still get the checpatch warning:
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
Still, I will add MAINTAINERS entries in each patch that adds files, instead of having a separate patch just for that.
> > Alex >
| |