Messages in this thread | | | Date | Thu, 18 Sep 2014 14:21:33 -0600 | From | David Ahern <> | Subject | Re: [PATCH 1/2] perf session: Add option to copy events when queueing |
| |
On 9/18/14, 12:53 PM, Arnaldo Carvalho de Melo wrote: > If nobody objects I'll merge this patch, as it fixes problems, but I > wonder if the best wouldn't be simply not calling > perf_evlist__mmap_consume() till the last event there is in fact > consumed... I.e. as we _really_ consume the events, we remove it from > there. > > Instead of consuming the event at perf_tool->sample() time, we would > do it at perf_tool->finished_round(), would that be feasible? Has anyone > tried this?
Hmmm... haven't tried this. Conceptually it should work - at least nothing comes to mind at the moment.
Patch looked ok to me: Reviewed-by: David Ahern <dsahern@gmail.com>
Jiri should review based on his recent changes for ordered events.
David
| |