lkml.org 
[lkml]   [2014]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] perf session: Add option to copy events when queueing
    On 9/18/14, 12:53 PM, Arnaldo Carvalho de Melo wrote:
    > If nobody objects I'll merge this patch, as it fixes problems, but I
    > wonder if the best wouldn't be simply not calling
    > perf_evlist__mmap_consume() till the last event there is in fact
    > consumed... I.e. as we _really_ consume the events, we remove it from
    > there.
    >
    > Instead of consuming the event at perf_tool->sample() time, we would
    > do it at perf_tool->finished_round(), would that be feasible? Has anyone
    > tried this?

    Hmmm... haven't tried this. Conceptually it should work - at least
    nothing comes to mind at the moment.


    Patch looked ok to me: Reviewed-by: David Ahern <dsahern@gmail.com>

    Jiri should review based on his recent changes for ordered events.

    David


    \
     
     \ /
      Last update: 2014-09-18 23:01    [W:3.178 / U:0.592 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site