lkml.org 
[lkml]   [2014]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] gpio: samsung: Remove remaining check for CONFIG_S5P_GPIO_DRVSTR
Paul,

On 18.09.2014 10:57, Paul Bolle wrote:
> On Thu, 2014-09-04 at 18:03 +0200, Arnd Bergmann wrote:
>> On Thursday 04 September 2014, Paul Bolle wrote:
>>> That check for CONFIG_S5P_GPIO_DRVSTR is still present in v3.17-rc3 and
>>> next-20140903. Should I submit the trivial patch to remove it (and the
>>> dead code it hides)?
>>
>> Yes, I think this one is an obvious candidate for removal.
>
> Still there in v3.17-rc5 and next-20140918. So I submit yet another
> trivial cleanup.
>
> Done on top of next-20140918. Only tested by grepping the tree. Please
> note that, obviously, nothing uses s5p_gpio_get_drvstr() or
> s5p_gpio_set_drvstr().
>
>
> Paul Bolle
> -------->8--------
> From: Paul Bolle <pebolle@tiscali.nl>
>
> Commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
> removed the Kconfig symbol S5P_GPIO_DRVSTR. It didn't remove one check
> for the related macro. Remove that check and the dead code it hides.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>

Thanks for the patch.

Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>

Best regards,
Tomasz


\
 
 \ /
  Last update: 2014-09-18 22:01    [W:0.080 / U:1.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site