lkml.org 
[lkml]   [2014]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cgroup: fix unbalanced locking
On Thu, Sep 18, 2014 at 05:28:46PM +0800, Zefan Li wrote:
> cgroup_pidlist_start() holds cgrp->pidlist_mutex and then calls
> pidlist_array_load(), and cgroup_pidlist_stop() releases the mutex.
>
> It is wrong that we release the mutex in the failure path in
> pidlist_array_load(), because cgroup_pidlist_stop() will be called
> no matter if cgroup_pidlist_start() returns errno or not.
>
> Fixes: 4bac00d16a8760eae7205e41d2c246477d42a210
> Cc: <stable@vger.kernel.org> # 3.14+
> Signed-off-by: Zefan Li <lizefan@huawei.com>

Applied to cgroup/for-3.17-fixes.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2014-09-18 19:01    [W:0.036 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site