lkml.org 
[lkml]   [2014]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6/9] eeepc-laptop: pull out SENSOR_STORE_FUNC and SENSOR_SHOW_FUNC macros
    Date
    Pull out EEEPC_SENSOR_STORE_FUNC and EEEPC_SENSOR_SHOW_FUNC. These
    macros define functions that call store_sys_hwmon() and show_sys_hwmon()
    respectively. This helps prevent duplication later on.

    Signed-off-by: Frans Klaver <fransklaver@gmail.com>
    ---
    drivers/platform/x86/eeepc-laptop.c | 12 +++++++++---
    1 file changed, 9 insertions(+), 3 deletions(-)

    diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
    index a85da4f..ba251bb 100644
    --- a/drivers/platform/x86/eeepc-laptop.c
    +++ b/drivers/platform/x86/eeepc-laptop.c
    @@ -1038,19 +1038,25 @@ static ssize_t show_sys_hwmon(int (*get)(void), char *buf)
    return sprintf(buf, "%d\n", get());
    }

    -#define EEEPC_CREATE_SENSOR_ATTR(_name, _mode, _get, _set) \
    +#define EEEPC_SENSOR_SHOW_FUNC(_name, _get) \
    static ssize_t show_##_name(struct device *dev, \
    struct device_attribute *attr, \
    char *buf) \
    { \
    return show_sys_hwmon(_get, buf); \
    - } \
    + }
    +
    +#define EEEPC_SENSOR_STORE_FUNC(_name, _set) \
    static ssize_t store_##_name(struct device *dev, \
    struct device_attribute *attr, \
    const char *buf, size_t count) \
    { \
    return store_sys_hwmon(_set, buf, count); \
    - } \
    + }
    +
    +#define EEEPC_CREATE_SENSOR_ATTR(_name, _mode, _get, _set) \
    + EEEPC_SENSOR_SHOW_FUNC(_name, _get) \
    + EEEPC_SENSOR_STORE_FUNC(_name, _set) \
    static DEVICE_ATTR(_name, _mode, show_##_name, store_##_name)

    EEEPC_CREATE_SENSOR_ATTR(fan1_input, S_IRUGO, eeepc_get_fan_rpm, NULL);
    --
    2.1.0


    \
     
     \ /
      Last update: 2014-09-18 00:21    [W:3.485 / U:0.660 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site